sugarlabs/musicblocks

dismissing an error message removeArrow() is not found

ashutoshgautams opened this issue · 18 comments

Steps to recreate :-

create a note with 4/1 as its note value. when you play it, a warning message appears. click on the x to dismiss the message... the arrow will not be removed.

image

closed in #3067
connected to #3065

the error with the arrow, it can be triggered by any error message, so, no, it is not yet resolved.

Can You please Elaborate on the place where it should be done? I want to contribute to this issue.

I couldn't find the problem, followed your steps

@Traitor000 plz assign this to me , I had already done this same functionality back on my hackathon project and quite familiar with it how it's done. Thanks

image

I didn't get what you want the program to do. Should the arrows be removed as soon as the 'X' button is hit or something else?

I have played note value 4/1 but i did not get any kind of warning message.

hideArrowsProblem
It seems like if you cancel any warning sign it can't find the "hide Arrows" function and couldn't remove arrows.

hideArrowsCodeSolve2
it seems like on "activity.js" "hideArrows" variable is defined but index.html can't access the function type variable. And this pis of code would solve the problem : // window.hideArrows = hideArrows; //

Hey @Traitor000, I've made a Pull Request. Could you see it, please?

Hi, Can I please help you in fixing it? I have good knowledge of JS and web-dev.

@Traitor000 Should I work on it if it's still not resolved?
Please assign this issue to me!

so can i help you in this i have a good amount of knowledge

i wanna help you in solving this issue.

@Traitor000 and @walterbender could you review this pull request, it solves the issue to the best of my knowledge

the error message
2

After dissiming the error message
3

i'd love to work on this issue or help and collaborate with whoever is working on it

I think this issue is fixed.

hey there, i would like to work this issue