suikan4github/kaiten-yaki

Remove loglevel dependency from the void-kaiten-yaki.sh

Closed this issue · 1 comments

void-kaiten-yaki.sh has a dependency on the string "loglevel=4", when it modify the /etc/default/grub of the host OS.

See the [source code]{

sed -i "s#loglevel=4#loglevel=4 ${GRUB_ADDITIONAL_PARAMETERS}#" /etc/default/grub
).

This works fine at 2021/July, but could be troublesome if Void Linux community changes its default log level or removes log level from the default option.

We can remove this dependency by replacing 2nd '"' of the GRUB_CMDLINE_LINUX_DEFAULT line by the additional parameter. For example :

sed -i -e  "/GRUB_CMDLINE_LINUX_DEFAULT/{s#\"#  ${GRUB_ADDITIONAL_PARAMETERS}\"#2}"  /etc/default/grub

Merged to develop.

Ready to release