sujaykumarh/docsify-plugin-title

[Bug]: Typo in seprator

gmartenscb opened this issue · 2 comments

Contact Details (optional)

No response

What happened? Describe the bug

The configuration currently accepts a seprator option.
The correct spelling for this would be separator.

To Reproduce

No response

Expected behavior

window.$docsify.customPageTitle.separator to be recognised

Your OS

iOS

What browsers are you seeing the problem on? (optional)

No response

App Version (optional)

No response

Relevant log output (optional)

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Eeek, this has been 'fixed' as a breaking change on a minor revision.

People using the suggested CDN snippet, which calls up version 1.x:

<script src="//cdn.jsdelivr.net/npm/@sujaykumarh/docsify-plugin-title@1.x/dist/plugin.min.js"></script>

Will have suddenly discovered that this functionality stopped working on their site, and had to come here to find out why. This should have been a major version number change, or have continued supporting the incorrect spelling such that it didn't break existing deployments.

Fixed with v2.0.0, thanks for bringing it up @AlexCPU. Cheers!