sumerc/concurry

make functions / types unexported?

Closed this issue · 2 comments

There are several warnings in the code. Your functions and variables start with UPPERCASE which means they are exported modules. And they require doc comments:

image

https://github.com/golang/go/wiki/CodeReviewComments#doc-comments

To make them un-exported / private, we should make them start with a lowercase letter, instead of uppercase.

Or, We should add doc-comments for everything which is something needs to be done either way

I didn't see any reason to export those types and functions. Should I open a Pull Request fixes this?

Forgot to install Go linter in my new setup :)

All fixed with some minor other fixes as well. Please you also check if there are more warnings on your end too and close the issue.

Thanks!

Great. Closing the issue...