sumup-oss/circuit-ui

Action icons: Send, View, Stop, Pause, Play

Closed this issue · 3 comments

Component to amend

Add missing icons for actions: Send, View, Stop, and update icons for actions: Pause and Play according to the changes in the Circuit UI Foundation Iconography.

Visual

The above mentioned icons were missing from the collection approved to use in Unified Invoices project (integrating Invoices in ze-dashboard):
Screenshot 2022-11-21 at 13 11 55
your component amendment.

Context

In what context does your amendment solve a problem?
We are adding status icons for corresponding invoice statuses.

Thanks for opening the issue, @ituraj! Sounds good to me.

You can follow the Contributing Icons guide to open a PR 🙂 (let me know if anything is unclear and I'll help)

I've also sent you an invite to join the org, so you can push a branch under the Circuit UI origin repository.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Add a comment explaining why the issue is still relevant to prevent it from being closed.

Oops, guess I forgot to post an update in here. Eventually after talking with design about this, we decided to release this set of icons under a different category (Notification) and under different names (Active, Paused and Stopped) (see #2018). No breaking changes for existing components (e.g. the Carousel) but enables the use of this variant of the start/pause/stop icons.

The icons have been available in the library since March in @sumup/icons@2.22.0, so you can now replace hardcoded icons in your app.

Thanks for your patience @ituraj!