sun-empire-solutions/meets-app

Improve modal styles

amendezm opened this issue · 6 comments

Hey, I think maybe making the text more exaggerated e.g. larger for "Join with a code", adding a bit more padding and centering/aligning a bit more after padding it up. What do you think?

@import-turtle Sounds good. Also add a max width to avoid that it does not look good on larger screens.

If you wanna propose other kind of style/design... feel free to help us

Ya that sounds like a great idea. I think for the login page, adding some padding at the top/bottom (mainly bottom) might make it look better because I'm checking it on mobile/my laptop (14-inch) and it looks a bit too close to the edge.

I would love to contribute to be honest, but I'm worried I might ruin your code since I'm new and couldn't orient myself to your files (e.g. for each component I like to pair it with css modules/styled-components/css modules with Sass to locally scope and then include it in the same folder).

O wait I found your styles folder containing the .scss. I could give it a shot if you would like.

@import-turtle yeah, feel free to code. The flow we are using is:

  1. create a new branch from updated main
  2. commit there
  3. open a PR with the linked issue

The styles are in a separated folder (we need to improve the folder structure/organization).

alexis.david.mendez@gmail.com send me an email to invite you to the slack workspace