sunt-programator/CodeIT

[BUG] Author tag is not show correctly in RSS file

Closed this issue · 2 comments

victor-pogor commented

Describe the bug

As @jadmadi reported on PR #113, the <author/> tag in the RSS XML file is not showing correctly. I checked the theme via W3C RSS Validator and I found two problems:

  1. Invalid email address: Author
  2. Self reference doesn't match document location: https://example.com/index.xml

I found that email should have a specific format. The problem is that not all authors would like to reveal their email. For this purpose, there is another tag (dc:creator). The value of the dc:creator element is less restrictive than the author element, which must contain an e-mail address.

Expected behavior

  • If the email is indicated in config.toml, show the author tag.
  • If the name is indicated in config.toml, show the dc:creator tag.
  • Show correct document location

Screenshots

image

Build Environment

  • OS: Windows 10
  • Theme v0.1.0
  • Hugo version 0.78.1

Preview Environment

  • OS: Windows 10
  • Browser Chrome
victor-pogor commented

Hi @jadmadi. I close the #113 PR since the changes were made in another PR.

Thank you for the contribution to this repo.

@all-contributors please add @jadmadi for code and bug

  • 👍1
allcontributors commented

@victor-pogor

I've put up a pull request to add @jadmadi! 🎉

  • 🚀1