[FEATURE] Make cookie use optional

[christoph-cullmann]

At the moment, per default one cookie (or local storage) is used to allow the user to store the dark/light theme selection.

It would perhaps make sense to have an option to avoid this (even if that means only the auto theme selection is possible), as this would allow to use the theme without the cookie banner.

If I missed how to do this now already, sorry, I read a bit the code and for me this seems at the moment to be unconditional.

[andyjenkins1]

Agreed this would be a good and would remove the need to have any cookies. Just wondering if any update on this?

[victor-pogor]

Hi all,

I looked at this item and I did the following:

If the params.cookieconsent.enable is false, then the theme option will not be written in the local storage.

https://github.com/sunt-programator/CodeIT/blob/22f7a81d055f37b81cfae46e866250db89e9c6fc/src/js/theme.js#L101-L108

https://github.com/sunt-programator/CodeIT/blob/22f7a81d055f37b81cfae46e866250db89e9c6fc/layouts/_default/baseof.html#L19-L22

Can you look at these modifications and share the opinion if the changes are ok?

[jesustorresdev]

Hi,

I think is best test against this.config.cookieconsent:

this.config.cookieconsent && window.localStorage && 
     localStorage.setItem("theme", this.isDark ? "dark" : "light"); 

layouts/partials/assets.html only set this.config.cookieconsent if params.cookienconsent.enabled is true.
If it is false, this.config.cookieconsent is undefined.

[victor-pogor]

Hi @aplatanado,

If the this.config.cookieconsent property will be undefined, the theme key in the localStorage will not be set (as expected).

Can you explain please what do you mean?
Thanks. 😉

[jesustorresdev]

Hi,

If the condition is:

this.config.cookieconsent.enable && .... 

then that line will fail with 'Uncaught TypeError: Cannot read property 'enabled' of undefined' when there is no 'cookieconsent' section in config file or enabled was set to false because in both cases this.config.cookieconsent is undefined. So I suggest just checking if this.config.cookieconsent is not undefined, as in:

https://github.com/sunt-programator/CodeIT/blob/22f7a81d055f37b81cfae46e866250db89e9c6fc/src/js/theme.js#L850-L852

[victor-pogor]

Ohh, understood you, I don't know where I looked in code yesterday because I remember only the this.config.cookieconsent (without enable). My mistake, sorry ))

I added your review in PR #207.

[christoph-cullmann]

Hmm, I must confess, I tried this, but for me, still the local storage is set, with 0.2.0, even without cookie banner.
Perhaps I am doing something wrong.

[victor-pogor]

@christoph-cullmann have you tried to disable the cookie consent?

 # Cookie consent config
  [params.cookieconsent]
    enable = false