Test file `z_15_ext_interface.out` is too big and preview doesn't work
Opened this issue · 1 comments
Problem
The nix/tests/expected/z_15_ext_interface.out is too big and doesn't preview on github. This hurts collaboration as one has to search the raw file when reviewing its changes.
- file preview doesn't work: https://github.com/supabase/postgres/blob/9bdefbcb7cc00b0692562c889b6c7d625120bd66/nix/tests/expected/z_15_ext_interface.out#L4754-L4755
- snippet preview doesn't work: https://github.com/supabase/postgres/blob/9bdefbcb7cc00b0692562c889b6c7d625120bd66/nix/tests/expected/z_15_ext_interface.out#L4754-L4755
roles.out for example does work in previews:
postgres/nix/tests/expected/roles.out
Lines 17 to 23 in 67fb756
Solution
Split z_15_ext_interface.out into other files. It tests functions signatures of extensions like postgis, vault, etc. Those can go into their own files. We already have postgis.out for example.
@steve-chavez it is my understanding that the .out file is generated by pg_regress
However if we split up the sql file with the same name in the nix/tests/sql directory, that should produce the results you are looking for.
In general we should not edit the .out files as they are generated