supabase/postgres

Test file `z_15_ext_interface.out` is too big and preview doesn't work

Opened this issue · 1 comments

Problem

The nix/tests/expected/z_15_ext_interface.out is too big and doesn't preview on github. This hurts collaboration as one has to search the raw file when reviewing its changes.

roles.out for example does work in previews:

rolname | rolcreaterole | rolcanlogin | rolsuper | rolinherit | rolcreatedb | rolreplication | rolconnlimit | rolbypassrls | rolvaliduntil
----------------------------+---------------+-------------+----------+------------+-------------+----------------+--------------+--------------+---------------
anon | f | f | f | t | f | f | -1 | f |
authenticated | f | f | f | t | f | f | -1 | f |
authenticator | f | t | f | f | f | f | -1 | f |
dashboard_user | t | f | f | t | t | t | -1 | f |
pg_checkpoint | f | f | f | t | f | f | -1 | f |

Solution

Split z_15_ext_interface.out into other files. It tests functions signatures of extensions like postgis, vault, etc. Those can go into their own files. We already have postgis.out for example.

@steve-chavez it is my understanding that the .out file is generated by pg_regress

However if we split up the sql file with the same name in the nix/tests/sql directory, that should produce the results you are looking for.

In general we should not edit the .out files as they are generated