superfluid-finance/protocol-monorepo

[ETHEREUM-CONTRACTS] Get rid of compiler warnings

Closed this issue · 2 comments

[build:contracts:foundry] Compiler run successful with warnings:
[build:contracts:foundry] Warning (2519): This declaration shadows an existing declaration.
[build:contracts:foundry]    --> packages/ethereum-contracts/test/foundry/agreements/gdav1/GeneralDistributionAgreement.t.sol:562:13:
[build:contracts:foundry]     |
[build:contracts:foundry] 562 |             uint128 memberUnits = pool.getUnits(members[i]);
[build:contracts:foundry]     |             ^^^^^^^^^^^^^^^^^^^
[build:contracts:foundry] Note: The shadowed declaration is here:
[build:contracts:foundry]    --> packages/ethereum-contracts/test/foundry/agreements/gdav1/GeneralDistributionAgreement.t.sol:536:9:
[build:contracts:foundry]     |
[build:contracts:foundry] 536 |         uint64[5] memory memberUnits,
[build:contracts:foundry]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[build:contracts:foundry] 
[build:contracts:foundry] Warning (2519): This declaration shadows an existing declaration.
[build:contracts:foundry]    --> packages/ethereum-contracts/test/foundry/agreements/gdav1/GeneralDistributionAgreement.t.sol:597:13:
[build:contracts:foundry]     |
[build:contracts:foundry] 597 |             uint128 memberUnits = pool.getUnits(members[i]);
[build:contracts:foundry]     |             ^^^^^^^^^^^^^^^^^^^
[build:contracts:foundry] Note: The shadowed declaration is here:
[build:contracts:foundry]    --> packages/ethereum-contracts/test/foundry/agreements/gdav1/GeneralDistributionAgreement.t.sol:569:9:
[build:contracts:foundry]     |
[build:contracts:foundry] 569 |         uint64[5] memory memberUnits,
[build:contracts:foundry]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[build:contracts:foundry] 
[build:contracts:foundry] Warning (5667): Unused function parameter. Remove or comment out the variable name to silence this warning.
[build:contracts:foundry]    --> packages/ethereum-contracts/contracts/apps/SuperTokenV1Library.sol:967:72:
[build:contracts:foundry]     |
[build:contracts:foundry] 967 |         returns (uint256 lastUpdated, int96 flowRate, uint256 deposit, uint256 owedDeposit)
[build:contracts:foundry]     |                                                                        ^^^^^^^^^^^^^^^^^^^
[build:contracts:foundry] 
[build:contracts:foundry] Warning (2072): Unused local variable.
[build:contracts:foundry]     --> packages/ethereum-contracts/test/foundry/FoundrySuperfluidTester.sol:1609:10:
[build:contracts:foundry]      |
[build:contracts:foundry] 1609 |         (int256 claimableBalance,) = pool_.getClaimableNow(member_);
[build:contracts:foundry]      |          ^^^^^^^^^^^^^^^^^^^^^^^

just do it

done in #1971