supriya-project/supriya

README has invalid instructions

keckler opened this issue · 6 comments

I don't really know anything about this software, but I tried to follow the startup instructions in the README and found that there are some calls that aren't valid. Specifically:

https://github.com/josiah-wolf-oberholtzer/supriya/blob/2ebf835ce9bbfca19e4220628a32c30fa66e04f7/README.md?plain=1#L90-L92

The Server/BaseServer object doesn't appear to have an add_synthdefs() method.

Are you talking about this add_synthdefs() method? https://github.com/josiah-wolf-oberholtzer/supriya/blob/main/supriya/contexts/core.py#L629

It's definitely there, although it might help me to know what version of Supriya you're running.

Python 3.9.2 (v3.9.2:1a79785e3e, Feb 19 2021, 09:06:10)
[Clang 6.0 (clang-600.0.57)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import supriya
>>> supriya.__version__
'23.7b0'
>>> server = supriya.Server().boot()
>>> _ = server.add_synthdefs(supriya.default)
In [3]: import supriya

In [4]: supriya.__version__
Out[4]: '23.2b1'

In [5]: server = supriya.Server().boot()

In [6]: _ = server.add_synthdefs(supriya.default)
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-6-a7c5f7e1f7ed> in <module>
----> 1 _ = server.add_synthdefs(supriya.default)

AttributeError: 'Server' object has no attribute 'add_synthdefs'

Using Python 3.7.2 from inside iPython.

You're quite a few versions behind the latest, so it's no wonder the current instructions don't work. Try upgrading.

You'll also want to use a newer version of Python. Recent versions of Supriya don't run on Python 3.7 anymore.

Huh, okay, this was just the version that pip grabbed for me. I didn't expect that it would be out of date.

But yep, you're right, upgrade fixed it. Sorry for the bother!

The version you got was probably the last version that supported Python 3.7 😄