"Fix" for GNOME 3.28 Apps

[p1u3o]

GNOME 3.28 apps don't have .image-button in the buttons in the headerbar, causing borders.

This seems to "fix" it. by fix it, a work around.

.titlebar button:not(.titlebutton):not(.text-button):not(.radio),
.titlebar .button:not(.titlebutton):not(.text-button):not(.radio)
{
    padding: 3px;
    border-radius: 99px;
    border: 1px solid transparent;
    background-image: none;
    box-shadow: none;

}

[surajmandalcell]

Can you tell me which application are you using? so i can test the same and merge if it works.

[p1u3o]

Geary, Corebird. Probably best for app specific work-arounds though.

Before

After

[p1u3o]

Also somewhat fixes Eolie.

[surajmandalcell]

I'm testing it rn, will check 2,3 apps and if it does not have any issues ill merge it!

[surajmandalcell]

So this happens to other elements
Before :

After :

[p1u3o]

I amended the original issue and that shouldn't happen anymore.

Polari is another application that has issues because it uses a frame element under a stack, which under Adwaita has no border, so can be copied with this.

stack frame {
    border: none;
}

Most of these issues are because the elementary stylesheet has yet to be updated. These tend to show up when using Flatpak versions of the app which are latest, but are relying on the older stylesheet.

[surajmandalcell]

I kind of fixed the issue using specificity but only tested on corebird, ill test it out on other apps (downloading pfft....)
Instead of lots of nots why not this

.titlebar button.toggle:not(.titlebutton),
.titlebar .button.toggle {
    border-radius: 99px;
    border: 1px solid transparent;
    background-image: none;
    box-shadow: none;
}

[surajmandalcell]

check the commit, i added your fix + fixed the eolie uri bar
b020b17

[p1u3o]

I think I tried just limiting the not to begin with, but some buttons don't have .toggle attached to them.

[surajmandalcell]

i only tested on eolie and corebird :(
What else do you use? ill install and test more apps for this then.

[surajmandalcell]

done, added your fix + hover effect

Tested on : eolie, corebird, gnome to-do

[surajmandalcell]

btw @ChocolateMilkGod what does

stack frame {
    border: none;
}

do again?

[p1u3o]

@surajmandalcell fixes squares in the channel list in Polari that contain the unread count.

[surajmandalcell]

crap, the recent changes affected native apps

Thinking of a way to only change stuff for gnome apps keeping elementary apps with default styling.