Issue with v1.

[TheGuyWhoo]

My gpu is old so I can only use v1. When I try to build it on win 10 for vcv rack 1.1.6, with sdk 1.1.6, I get this error:

    surge/src/common/Parameter.cpp:774:24: error: 'numeric_limits' is not a member of 'std'
      774 |       val_min.i = std::numeric_limits<int>::min();
          |                        ^~~~~~~~~~~~~~
    surge/src/common/Parameter.cpp:774:39: error: expected primary-expression before 'int'
      774 |       val_min.i = std::numeric_limits<int>::min();
          |                                       ^~~
    surge/src/common/Parameter.cpp:775:24: error: 'numeric_limits' is not a member of 'std'
      775 |       val_max.i = std::numeric_limits<int>::max();
          |                        ^~~~~~~~~~~~~~
    surge/src/common/Parameter.cpp:775:39: error: expected primary-expression before 'int'
      775 |       val_max.i = std::numeric_limits<int>::max();

Hope you will help even though v1 is old news.

[TheGuyWhoo]

nevermind, parameter.cpp needs

#include <limits>

[TheGuyWhoo]

Fails to load with this message

[34.302 warn src/plugin.cpp:158] Could not load plugin C:\Users\nick\DOCUME~1/Rack/plugins-v1/SurgeRack: Failed to load library C:\Users\nick\DOCUME~1/Rack/plugins-v1/SurgeRack/plugin.dll: code 127

[baconpaul]

The makefile I think adds an Ilimits but not sure

which hash are you checking out?

honestly don’t really have capacity or environment to debug rack 1 on windows 10. But doesn’t rack 1 still have a working binary in the library?

[TheGuyWhoo]

I checked out branch final_v1. Unfortunately for whatever reason it doesn't still have binaries for v1. Maybe you do?

[baconpaul]

I don’t - I wonder if I cleaned them out when v2 shipped and we moved to xt

can you still subscribe in the rack library?

[TheGuyWhoo]

Yes I can

[Petervos2018]

Yes I can

Then you should be offered/able to download a compiled version via Rack, or am I missing the point.
Do you want to compile it yourself ?

[TheGuyWhoo]

You likely have a binary from before it was taken out of the library. The problem is that when I build it rack refuses to load the plugin with error code 127, as I said.

[TheGuyWhoo]

Would you mind sharing you binary here please?

[Petervos2018]

https://filebin.net/qlw52ogdy4oe3aeo

Does this work ?

[TheGuyWhoo]

Absolute legend, that works! Thanks man.

[baconpaul]

OK great. Closing this. Thanks for the help @Petervos2018

still not entirely sure why its not in the library but glad its solved!