surgitaix/sdclib

Build question

Closed this issue · 4 comments

In attempting to build, it hangs just after the following:
[ 30%] Building CXX object CmakeFiles/SDCLib.dir/src/Data/SDC/SDCProviderAdapter.cpp.o
There are a number of warnings. Would it be helpful to provide a list of all of them? The last line I can see is:
/home/pi/OSCLib/osclib-develop/src/Data/SDC/SDCProvider.cpp:1239:8: warning: the compiler can assume that the address of 'source' will always evaluate to 'true'
Any suggestions? Let me know if you would like to discuss... Thanks!

Hello beachburghbrian. I'm sorry I'm late on this issue. I'm currently working on the SDCLib.
I get a similar warning. My compiler (GGC 8.2) tells me that the address of source will never be NULL.
The variable source is a template parameter and is currently deduced as (const) lvalue reference. As consequence the address operator with the variable &source will result in an redundant expression what the compiler will warn you about.
My first step will be to replace this expression by std::addressof(source) what is generally recommended when using templates and & operator (in case the passed value overloads the & operator differently).
I cannot tell you when this will be merged in to the master branch and hope this will satisfy your question. I'm sorry this answer is so late.

Thank you for your feedback!
Again, sorry for the late reply.