surpher/PactSwift

Task: Move Build Phase scripts into script files

surpher opened this issue ยท 3 comments

โ• Problem Statement

macOS target contains a couple of Build Phase scripts that are written in the Build Phase themselves. This is not ideal and should be pulled out into a script file.

๐Ÿ’ฌ Task Description

Pull out the scripts in Build Phases into script files and move into /Scripts/BuildPhases:

Targets:

  • PactSwift_macOS
  • PactSwift_iOS

BuildPhases:

  • Cargo build (libpact_mock_server.a)
  • Move the "check for rust" block of code in ./Scripts/build_file_list_and_swiftlint file into it's own script file to be individually referenced from either a BuildPhase or GitHub workflow step

๐Ÿ‘ฉโ€๐Ÿ”ง Technical Design Notes

  • No scripts that are called from Build Phase are to install anything - it should only check for availability of the tools and stop the build (eg: non zero return from script) if required tools are missing, and clearly display what the problem is.
  • Build Phase script should reference the script file to run
  • See Build Phase Swiftlint and ./Scripts/BuildPhases for guidance
  • Script filenames to not contain extension (eg. .sh) as first line in the script should imply it's a shell script.

๐Ÿค Relationships

  • Other Related Issues/PRs: #41

Hey, I would like to give it a shot! Can you please assign this to me?

Thanks! ๐Ÿ‘

I have added a few more details so it should be easier to complete this task.

I have made some minor changes to existing PactSwift_macOS scheme and its Build Phases in #45.