surrealdb/surrealdb.py

Line length

CaedenPH opened this issue · 7 comments

What should the code line length be? pep-8 suggests 79 characters, black defaults to 88, what would you guys suggest?

I just checked python poetry code and it seems as they switched to 88, I consider that safe since we use +100 in the company that I work for :)

So 88 I vote

I'd also lean towards 88, one less line of config and all

79 leads to harder to read code in my opinion.
100+ is okay for private projects, but 88 is a happy medium for the best mix of accessibility and readability for all.

What about black? https://github.com/psf/black

we're already using black, and i don't plan on changing the line length of black unless most people think it should. from what i gather, most are suggesting ~88 and hence i will not change it

I'll close this issue for now as it seems most people think 88 is a good number. Also if black defaults to 88, then that should be fine for the moment 👍😀!