surrealdb/surrealkv

This is not `chore:` is a `feat:`

Miuler opened this issue · 3 comments

Miuler commented

This is not chore: is a feat:

chore: updating grunt tasks etc; no production code change

I am seeing that in all commits they are using chore, which confused me since this is used for things like ci, tasks in makefiles or cargo make, but not to modify code. Even angular stopped using chore: to use other things like ci: among others.

Please stop using chore, it is not suitable for these commits that modify the code.

Hi @Miuler

Thanks for raising concern about commit messages. We squash commits on merge with a "feat" message, following conventional Commits. While "chore" may seem unconventional, it serves its purpose during development.

But I notice that this wasn't used for the initial PR. Will rectify it. Thanks for catching it.

Miuler commented

In the add-store branch, the commit message is not correct:

image

image

Miuler commented

mmm... ok, although it would be a great squash