suyashkumar/ssl-proxy

Generation of redirect URL goes to https://0.0.0.0

Closed this issue · 6 comments

amenk commented

I am using that docker container https://github.com/AddisMap/ssl-proxy-docker/tree/patches with

-from 0.0.0.0:443 -redirectHTTP -domain example.com

Now it would redirect to https://0.0.0.0:443

-from example.com:443

would not work, because it cannot bind to the address (maybe because it's in the docker container)

Can't we just use the -domain value for redirection?

suyashkumar commented

Hi there! Apologies for the delay (lots going on lately), and thanks for raising this issue!

Yeah, I think we should improve the -redirectHTTP logic here. If a domain is specified, we should use that value during redirection.

If a -domain is not specified, I think we should probably continue to use the base from URL. In this case if its a 0.0.0.0 type address, then it'll redirect to localhost (which would mostly be useful just for local development). I think the user may be able to supply the public IP address of the server as well here if they wanted.

  • 🎉1
amenk commented

@suyashkumar Awesome - thanks! can you tag a new release and I will test it :)

  • 👍1
suyashkumar commented

Yep! Prebuilt binaries are now available under releases, and you can always grab the latest prebuilt binaries to your machine using:

wget -qO- "https://getbin.io/suyashkumar/ssl-proxy" | tar xvz

Of course you can always build from source--the new tag is v0.2.6. Let me know how that works out for you, and if you have any other questions, suggestions, or contributions! Thank you again for filing the issue! :)

  • 👍1
amenk commented

sorry for the late response. I can confirm it works well. Just updated https://github.com/AddisMap/ssl-proxy-docker/tree/patches

Thank you very much.

  • 👍1
suyashkumar commented

@amenk awesome, glad to hear it. No problem :).

sugoidogo commented

I'm having this issue as well with -from 0.0.0.0:443 -to 127.0.0.1:8080 -redirectHTTP when trying to reach a site on my internal network.