suzuki-shunsuke/tfcmt

Creating a label fails when label length is too long

Closed this issue · 3 comments

itkq commented

We have a terraform monorepo and are using tfcmt for terraform plan CI. Creating label sometimes fails due to such deep hierarchies like:

tfcmt-failure

The plan output is available, but we're in trouble when there's many changes like updating dependencies across tfstates because it will be hard to judge if there's a change by the labels. I couldn't find the official document that describes the quota, but I found out the maximum characters is 50 from the Web UI.

image

Here's a basic approach to the problem: Omit the head of the label when it's too long. I'd like to submit a PR in this way, but I'm wondering if this behavior should be optional.

Thank you for your report.
As you said, this is a limitation of GitHub.

Here's a basic approach to the problem: Omit the head of the label when it's too long.
I'd like to submit a PR in this way, but I'm wondering if this behavior should be optional.

I think tfcmt shouldn't omit the pull request label, because the label for the other service may be set wrongly.

you should shorten the target value yourself.

The pull request label should be unique and human readable.
So tfcmt shouldn't omit the pull request label mechanically.

itkq commented

On the second thought, shortening the label by tfcmt caller is enough for our case. Thanks for the comment! Closing