svartalf/rust-battop

Windows support

svartalf opened this issue · 8 comments

svartalf commented

This is a tracking issue for Windows support.

Main problem is that termion backend for tui dependency does not support Windows terminals.

Another option for tui - crossterm supports Windows and should be considered as a replacement.

svartalf commented

Possible switch to crossterm is blocked by this issue: crossterm-rs/crossterm#81 (I think), since it is important for battop to handle ←, → and ^C key combinations.

svartalf commented

Note to myself: blocking PR was closed, nothing should block windows support now.

svartalf commented

And it is blocked by this PR now: fdehau/tui-rs#150

svartalf commented

Almost done, blocked only because there is no tui crate release with the changes from this PR: fdehau/tui-rs#153

bew commented

Hello, just discovered this nice tool!
Is it still blocked? 🙄

svartalf commented

No, it is not blocked anymore, switch to crossterm backend for tui should be done, but I don't really have time to do that now.

PRs are more that welcome!

ratijas commented

Interesting to the point at which I'm almost willing to give it a try.

What was the whole point, again? Terminal UI library, which is being used now, provides too much capabilities that cannot be replicated on Windows, so devs just gave on supporting it, and thus it fails to even compile? So we need to move on to a less capable library which would support the lowest common denominator of all platforms. Am I getting this right?

svartalf commented

@ratijas the idea is to pick up terminal UI library, which will provide the same interface (or, at least the almost same) as in the current implementation, while also providing support for at least Linux, macOS and Windows. If it will also support *BSD family, that will be a great bonus.

I'm not aware about current state of termion crate, but the idea to switch to crossterm still stands.

Does this answers your question?