sveinbjornt/Platypus

platypus 5.4.1 src.zip file: unzipping and symbolic link issue

iMichka opened this issue · 1 comments

Hello. Homebrew maintainer here. I just noticed that the src.zip file of the 5.4.1 release is in a weird state.
When I try to unzip it on macOS, unzipping exits with status code 1

Here is the error message:

warning:  skipped "../" path component(s) in ../
warning:  skipped "../" path component(s) in ../Common.m
  inflating: ./Common.m
warning:  skipped "../" path component(s) in ../Documentation/
warning:  skipped "../" path component(s) in ../Documentation/Documentation.html
... snip ...
warning:  skipped "../" path component(s) in ../Sparkle/dsa_pub.pem
  inflating: ./Sparkle/dsa_pub.pem
warning:  skipped "../" path component(s) in ../build_release.sh
  inflating: ./build_release.sh
finishing deferred symbolic links:
  ./Tests/platypus       -> /Users/sveinbjorn/Projects/platypus/products/platypus_clt
  ./Sparkle/Sparkle.framework/PrivateHeaders -> Versions/Current/PrivateHeaders
  ./Sparkle/Sparkle.framework/Resources -> Versions/Current/Resources
  ./Sparkle/Sparkle.framework/Versions/Current -> B
  ./Sparkle/Sparkle.framework/Autoupdate -> Versions/Current/Autoupdate
  ./Sparkle/Sparkle.framework/Updater.app -> Versions/Current/Updater.app
  ./Sparkle/Sparkle.framework/Headers -> Versions/Current/Headers
  ./Sparkle/Sparkle.framework/XPCServices -> Versions/Current/XPCServices
  ./Sparkle/Sparkle.framework/Modules -> Versions/Current/Modules
  ./Sparkle/Sparkle.framework/Sparkle -> Versions/Current/Sparkle
  ./Sparkle/old/Sparkle.framework/PrivateHeaders -> Versions/Current/PrivateHeaders
  ./Sparkle/old/Sparkle.framework/Resources -> Versions/Current/Resources
  ./Sparkle/old/Sparkle.framework/Versions/Current -> A
  ./Sparkle/old/Sparkle.framework/Headers -> Versions/Current/Headers
  ./Sparkle/old/Sparkle.framework/Modules -> Versions/Current/Modules
  ./Sparkle/old/Sparkle.framework/Sparkle -> Versions/Current/Sparkle

I found a way to unzip the file though, with https://unix.stackexchange.com/a/319623

unzip -: platypus5.4.1.src.zip

It does unzip the file, but at ../, so outside of the directory where I want it to be unzipped. I think that using -: is a bad idea anyway.

Could the release process be changed to make a zip archive that unzips without exit code 1, in the right folder?

Bump, would be great to have the latest version of platypus at homebrew