Remove circular dependency

Question

Remove circular dependency

Closed this issue 3 years ago · 9 comments

Circular dependency: src/node_modules/@sapper/app.mjs -> src/node_modules/@sapper/internal/App.svelte -> src/routes/_layout.svelte -> src/node_modules/@sapper/app.mjs

We should fix this. _layout doesn't need to depend on the whole app. Only on the stores for example. We could refactor out the stores such that the layout and app can both import them independently without the need for this circular dependency

Answer 1 · 2020-09-22T14:16:41.000Z

You mentioned this results in a warning. Where can I see this warning?

Answer 2 · 2020-09-22T15:33:34.000Z

It's been silenced in the Rollup config, so you would need to remove that: https://github.com/sveltejs/sapper-template/blob/b756d9df6157bb13611e53627ddeecd440432121/rollup.config.js#L16

Answer 3 · 2021-04-19T19:07:14.000Z

@benmccann it didn't work

Answer 4 · 2021-04-19T19:22:00.000Z

I'm not going to fix this. Focusing on SvelteKit now which replaces Sapper

Answer 5 · 2021-04-20T02:17:51.000Z

@benmccann How ready is sveltekit so far? to handle routing, ssr etc ?

Answer 6 · 2021-04-20T03:07:35.000Z

Yes, it does that already

Answer 7 · 2021-04-20T04:10:05.000Z

do you recommend using sveltekit then for a large ecommerce project, or sapper is more stable so far?

Answer 8 · 2021-04-20T13:53:23.000Z

SvelteKit had more functionality and better development experience. It is more likely to introduce bugs or API changes though if you lock to a working version hopefully you can address those in your own time. There's also the question of whether you'd want to start a new project in Sapper only to migrate later

Answer 9 · 2021-04-20T20:48:18.000Z

I understand! so i will keep using sapper, and upgrade later to sveltekit.
i'm sure the process will be easy!