svitejs/vite-plugin-qrcode

Enable QR in vite preview mode

Closed this issue · 6 comments

develohpanda commented

Describe the problem

Currently the QR code only displays when vite is running in dev mode, ie. vite serve. When testing a PWA, we are also building the site locally using vite build, then previewing it using vite preview.

I'd like to be able to view the QR code when vite is running in preview mode via vite preview as well.

Describe the proposed solution

An additional preview option, which can default to false, to preserve existing behavior but allow developers to opt-in to showing the QR code during vite preview.

Alternatives considered

No alternatives at this stage - potentially forking the project.

Importance

would make my life easier

dominikg commented

This could be pretty easy to implement using the configurePreviewServer hook https://vitejs.dev/guide/api-plugin.html#configurepreviewserver similar to how we already use configureServer here https://github.com/svitejs/vite-plugin-qrcode/blob/main/packages/vite-plugin-qrcode/src/index.ts#L8

Would you like to contribute this? PR welcome.

  • 👍1
develohpanda commented

Certainly 👍 will raise a PR when I get a chance!

develohpanda commented

Hi @dominikg & @bluwy, I've been looking at this; unfortunately configurePreviewServer doesn't have the same signature as configureServer but more importantly doesn't provide the data that is needed - the resolvedUrls and the logger...

Would you have any suggestions on how I should approach this?

bluwy commented

Hmm looks like you're right. We could get logger with the configResolved hook, but resolvedUrls is tricky unless we re-implement it ourselves. Another way is to send a PR to Vite to provide the PreviewServer type in the configurePreviewServer hook instead.

dominikg commented

Hmm looks like you're right. We could get logger with the configResolved hook, but resolvedUrls is tricky unless we re-implement it ourselves. Another way is to send a PR to Vite to provide the PreviewServer type in the configurePreviewServer hook instead.

i think updating the configurePreviewServer hook in vite is a good idea. Even better that vite-4 is currently in alpha so doing it now has a nice chance of getting included. esp if it aligns the hook api's to be more similar.

  • 👍1
develohpanda commented

I'll try get a PR up for Vite soon. Good call on Vite 4 being alpha, I've been keeping an eye on that for the Rollup upgrade too.

  • 👍1