svobik7/next-roots

How to generate route with optional catch-all segments?

Simas06 opened this issue · 6 comments

Simas06 commented

Hello,

Can't get it to work with app router and optional catch-all segments
https://nextjs.org/docs/pages/building-your-application/routing/dynamic-routes#optional-catch-all-segments

Page example:
src/roots/category/[[...slugs]]/page.js

How should route for such page be generated with dynamic slugs?

svobik7 commented

Hi @Simas06 , thank you for pointing this out. I added support for optional catch all routes. Please update to the most recent version of next-roots package and try. I added example usage to examples/basic

  • 👍1
Simas06 commented

Thank you, it works! Also would be great to have support for not optional catch-all segments also

For example:
src/roots/category/[...slugs]/page.js

svobik7 commented

Afaik I added support for both. Could you please try @Simas06 ?

Simas06 commented

Tried again, still not optional catch-all route generation ignores passed parameters.

svobik7 commented

Hi @Simas06, the new version 3.6.0 covers non-optional routes. See example https://github.com/svobik7/next-roots/tree/master/examples/basic/src/routes/books/%5B...slugs%5D

Could you please test on your end?

  • 👍1
Simas06 commented

It works now, thank you!