Feature: Firefox extension

Question

Feature: Firefox extension

Closed this issue 7 years ago · 12 comments

i dont use firefox myself but i think we should try to support more browsers than chrome. there is demand for this per this HN comment: https://news.ycombinator.com/item?id=16725476

Answer 1 · 2018-04-01T00:04:34.000Z

I submitted a PR for this- #7- but you'll need to go through some rigamarole to submit & get it listed in the Firefox Add-ons directory.

Answer 2 · 2018-04-02T23:46:11.000Z

i'll try it. never done it before. thank you!

Answer 3 · 2018-04-02T23:54:04.000Z

i have submitted to https://addons.mozilla.org/en-US/developers/addon/async-render-toolbox/, fingers crossed

Answer 4 · 2018-04-03T04:43:19.000Z

Very cool add-on (love the way it sets up its little window/panel. I'm a sucker for GUIs).

One of the reasons I'm glad to be a Mozilla content reviewer (might've missed it otherwise).

Answer 5 · 2018-04-03T14:14:16.000Z

thank you! yay.

Answer 6 · 2018-04-03T19:27:33.000Z

BTW: Not sure if that's the intention, but CTRL+R doesn't actually just toggle the overlay but refreshes the entire website. At least on a UK keyboard.

Answer 7 · 2018-04-03T20:10:05.000Z

thats not the intention at all. are you on windows? can you suggest a better shortcut that would work across mac and windows? im on mac.

…

On Tue, Apr 3, 2018 at 3:27 PM, Happy-Ferret ***@***.***> wrote: BTW: Not sure if that's the intention, but CTRL+R doesn't actually just toggle the overlay but refreshes the entire website. At least on a UK keyboard. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#6 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AiT1grNw_QqSCV4PVE4sz9E-2P7I6uOLks5tk80mgaJpZM4TCpLk> .

Answer 8 · 2018-04-03T20:57:30.000Z

I love the extension and will definitely be using it for development in the future, thanks! That said, on Linux the shortcut also refreshes the page. Maybe clicking on the extension's icon could toggle it?

Answer 9 · 2018-04-03T21:45:59.000Z

ok but i would really like to find a nice cross platform keyboard shortcut...

Answer 10 · 2018-04-04T07:53:46.000Z

Running the extension through about:debugging there are a few "bugs"/inconsistencies that produce warnings/errors.

I'm not a code reviewer over at Mozilla AMO so I didn't test for these, and I doubt any of these are serious enough to have your add-on pulled.

Still. Would you mind if I helped you fix them? If for nothing else, then we might as well please erosman (praise be unto him😜).

Answer 11 · 2018-04-04T14:24:35.000Z

not at all, PR away :) my main focus is adding a new service worker feature to intercept requests now, if it works its going to be so sick for react suspense

…

On Wed, Apr 4, 2018 at 3:53 AM, Happy-Ferret ***@***.***> wrote: Running the extension through about:debugging there are a few "bugs"/inconsistencies that produce warnings/errors. I'm not a code reviewer over at Mozilla AMO so I didn't test for these, and I doubt any of these are serious enough to have your add-on pulled. Still. Would you mind if I helped you fix them? If for nothing else, then we might as well please erosman (praise be unto him😜). — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#6 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AiT1gkPlwjKVuR2Y0WVOXMbGSIc-6vPeks5tlHwKgaJpZM4TCpLk> .

Answer 12 · 2018-04-04T14:38:20.000Z

See #9

Can't fix the other two error messages (well. Warnings, really. Since the extension will still work), unfortunately. They'll have to be fixed upstream.

Been a while since I last implemented a new Webextension API for Firefox, but this might really inspire me to do so.