swami/swami

Bug: some SpinButton widgets doesn't update values correctly.

Closed this issue · 5 comments

jjceresa commented

In Misc. Controls panel:
1)For Coarse Tune, Fine Tune, Scale Tune :
1.1) Doing successive one click left-button-mouse on SpinButton doesn't update the value correctly. (i.e the value isn't incremented (or decremented) as expected).
1.2) For each click, we got this message on stdout:
** (swami.exe:2692): CRITICAL **: file ....\libinstpatch\libinstpatch\IpatchUnit.c: line 479: assertion `src_info != NULL' failed.

2)For Filter Q, Reverb, Chorus, Pan
Same issues than 1.1 only.

I have fixed those issues here. Before doing a PR, please do these issues happen on Gtk Linux ?

derselbst commented

Sry, I won't be able to test this until December. But there were many assertions when using Swami, this it's quite likely.

jjceresa commented

Ok, no problem. I just need to be sure that Gtk widget behaviour is the same on Linux or Windows.
I will wait.

derselbst commented

please do these issues happen on Gtk Linux ?

Confirmed. See attached file for all assertions.
swami-assertions.txt

jjceresa commented

Confirmed.

Thanks. I will do 2 PRs to fix each case (1) and (2).

See attached file for all assertions.

Ohhhhh, you got a bunch of severe assertions !. Most of these assertions are related to
Failed to load UI XML file 'share/swami/swami-2.ui. It sounds like this important file is missing ?.

Here, swami/swami-2.ui is really installed by the INSTALL target and this file is correctly found by Swami.

derselbst commented

It seems that CMAKE_INSTALL_DATADIR may not be correctly initialized on linux. Shouldn't matter too much, all packagers I came across so far explicitly set it when compiling for their distribution.