swiftlang/swift-syntax

Improve performance of `SyntaxVisitor`

Closed this issue · 1 comments

When @StevenWong12 authored #2087, we noticed that the new SyntaxVisitor-based implementation is 50% slower than the old implementation. It looks SyntaxVisitor is performing quite a few more retain and release calls that might not be necessary. We should investigate if there’s something we can do about that.

For newcomers to the project: Note that this is a fairly advanced issue. It will require debugging code at the SIL level and I’m not sure if there’s a road to success.

Tracked in Apple’s issue tracker as rdar://114330163