swiftlysingh/SpaceDash

Network manager leaking memory

devwaseem opened this issue · 1 comments

The network manager holds a strong reference to its delegates. so the class assigned as a delegate to network manager is never released due to strong memory reference. I'm attaching profiler screenshots supporting for my issue.

Screenshot 2020-10-02 at 4 15 16 PM

I opened the DetailsViewController 3 times while profiling, you can see 3 persistent and 0 transient objects. this means the DetailViewController is never released.

Screenshot 2020-10-02 at 4 15 35 PM

This screenshot is from memory Graph debugger indicating the leaked objects

Screenshot 2020-10-02 at 4 28 45 PM

Assign me. I'll make a PR solving this issue