Deal with “illegal static override” symbols

Question

Deal with “illegal static override” symbols

j-f1 opened this issue 4 years ago · 1 comments

They all look like they can be made into class methods, so I’m not sure why that isn’t the case.

https://github.com/swiftwasm/DOMKit/blob/271ef4156da79632e90ea6e41688394cdddea991/Sources/WebIDLToSwift/WebIDL%2BSwiftRepresentation.swift#L450-L455

https://github.com/swiftwasm/DOMKit/blob/271ef4156da79632e90ea6e41688394cdddea991/Sources/WebIDLToSwift/WebIDL%2BSwiftRepresentation.swift#L496-L501

Answer 1 · 2023-01-29T17:03:08.000Z

Fixed in 493bf5d. I was just setting up the context incorrectly, so the methods were incorrectly declared as static rather than class. They‘re declared as class now. Also, I’ve had to manually patch a few that are overrides in JS (since only the first part of the name counts) but aren’t in Swift (since the parameter names/counts differ).