Use Font Awesome Icon in Menu
rjha999 opened this issue · 5 comments
How can I use font awesome Icon in this Jquery context Menu? Please help me for this.
I've made 2 simple changes that allow to use FontAwesome, if will be accepted you can use it easly.
+1
Should be able to do this with the callback option :)
Seems a bit inefficient to do that via callback. Having a class(es) name
option on icon that would work as an override of default class(es) during
configuration would think to be better and easier for use.
On Aug 30, 2015 7:25 AM, "Björn Brala" notifications@github.com wrote:
Should be able to do this with the callback option :)
—
Reply to this email directly or view it on GitHub
#249 (comment)
.
Yeah it is slightly more inefficient, but not by much if you just return a icon string. By changing the way it works when you just add a string we would break old code everywhere. I rather not break backwards compatibility. The callback also serves some other purposes like making the icon dependant on the state of something else.
I'm not ready to break backwards compatibility on this. I would consider this only when there might be a redo of the way the css is structured, but i don't feel confortable doing that yet.