swissspidy/preferred-languages

JS Translations: Many calls to `is_readable`

Closed this issue · 3 comments

spacedmonkey commented

The function preferred_languages_load_script_translation_file calls is_readable ALOT.

In my testing, it called, it around 1.5k times.

Screenshot 2023-04-26 at 15 45 18

swissspidy commented

On which screen is this and what's your setup, i.e. what's your preferred languages list, active plugins, is translation merging enabled?

In my quick testing this function was not called that often.

I did find #676 though which definitely fixes a bug and should improve numbers.

spacedmonkey commented
  • WordPress core development.
  • Plugins, this, web stories, CF7, Sitekit.
  • Language setup, En_UK, EN_Ca.
  • Used blackfire on web stories edit screen.
  • 👍1
swissspidy commented

Thanks, that's already helpful!

While I don't get such high numbers, #676 does have quite an impact on the Web Stories edit screen.