switchfeat-com/switchfeat

feat(ui): add notifications

dev-bre opened this issue · 9 comments

dev-bre commented

As a developer I would like to use a generic notification system which can be used in multiple places in the UI.

Every time the user execute an action, like create a flag, delete, update etc a notification should show up to either confirm success or show an error.

All pages should share the same approach to showing notifications. Might be good to have a notification provider or something.

Zeeshnhmd commented

Can you explain more about the issue?

  • 👍1
dev-bre commented

You are totally right. I updated the description with some context.if you have questions just shout.

I see there is PR already which has a notification system in it, but that PR is not going to be merged since it is not enough focused on the issue. Might be worth looking at it maybe as well.

Zeeshnhmd commented

ok so in that case how about using Toastify.js https://github.com/apvarun/toastify-js/blob/master/README.md

dev-bre commented

I have used this: https://react-hot-toast.com/ in the past which works perfectly with React.

github repo: https://github.com/timolins/react-hot-toast

I would rather have this on, if that works for you.

Can I assign this task to you?

Zeeshnhmd commented

Yes, it is a good idea to use react-hot-toast. I have some points to clear up.

  1. Do I need to do the changes in the UI folder?
  2. I am going to create a reusable component for notification with all the props react-hot-toast provides.

Suggestion: Why are you guys not using AntDesign? It's a great UI library for UI components.

Yes, you can assign this task to me.

Thank you.

dev-bre commented

Cool.

  1. Yes please all changes related to the react app should go in there

  2. Sounds great!

  3. I am using Tailwind which is a phenomenal UI library. I would like to keep it without adding more libraries into the mix.

Thanks!

dev-bre commented

@Zeeshnhmd do you have any plans on when you can work on this?

Zeeshnhmd commented

Hey, @dev-bre raised a PR please have a look and let me know if you need any changes.

Thank you.

dev-bre commented

@Zeeshnhmd here it is how I modified your provider to support Tailwind styled content. #39 . Thanks for your PR, it opened the way to this customization.