sybrew/the-seo-framework

Home page Meta Box title breaks Gutenberg panel

Closed this issue · 4 comments

jhned commented

Describe the bug
Gutenberg uses the meta box title under Options (three-dot menu) -> Preferences -> Panels. It is not expecting the Meta Box title to have HTML in it, and displays the full HTML for the tooltip, instead of the tooltip itself.

How to reproduce the bug
Steps to reproduce the behavior:

  1. Go to the home page
  2. Click on Options (the three-dot menu)
  3. Scroll down and click on Preferences
  4. Click on Panels
  5. See error

Expected behavior
Meta box name without garbled HTML.

Screenshots
image

Additional context
This is happening in version 4.2.8 on WordPress version 6.2.

sybrew commented

We may want to address this upstream. I'll investigate whether HTML is permitted, condoned, or forbidden. I was under the impression of the second.

Thank you for reporting!

  • 👍2
sybrew commented

The meta box displays the tooltip as I intended it to.

image

The preference panel displays escaped HTML, as I didn't intend it to.

sybrew commented

When put in the sidebar, it's a mess.

image

@Dashlane is still being asinine by ignoring autocomplete=off.

sybrew commented

We may want to address this upstream

I doubt it'll be addressed this decade, so I just moved the warning elsewhere: to a spot less likely to be missed by users. We still get too many support questions about these setting fields.

image

As for the aforementioned "mess" in the sidebar: I removed the "Homepage " part of the settings header.