Doesn't work with ivy-hydra
Opened this issue · 1 comments
kangjianbin commented
Reproduce:
- Enter ivy (SPC b b)
- Enter hydra-ivy (C-o)
- Press escape sequence to exit minibuffer
I found that ivy exited but hydra-ivy didn't exit.
I changed =evil-escape--escape-normal-state= to
(defun evil-escape--escape-normal-state ()
"Return the function to escape from normal state."
(cond
((and (fboundp 'helm-alive-p) (helm-alive-p)) 'helm-keyboard-quit)
((eq 'ibuffer-mode major-mode) 'ibuffer-quit)
((eq 'image-mode major-mode) 'quit-window)
((evil-escape--is-magit-buffer) 'evil-escape--escape-with-q)
((bound-and-true-p isearch-mode) 'isearch-abort)
((window-minibuffer-p) (kbd "C-g"))
(t (lookup-key evil-normal-state-map [escape]))))
And it works. The reason is that hydra-ivy also binds "C-g" to exit.
syl20bnr commented
Are you still using evil-escape
? If yes and this change has been stable for you, I would be happy to merge this change.