BaseAdminExtension refactor
dbu opened this issue · 3 comments
we should eliminate the enabled explicit field and map it to the publishable field added in #101 instead. it is pretty redundant.
this leaves only the ttl field in the BaseAdminExtension class. i think we should still keep that, as its a way to control where you want the ttl to be editable. the extension should go into Admin/Extension and make it have Block in the name.
ok so for the name do you think BlockExtension is good or BlockCacheExtension ?
I can do it after #97
lets call it BlockCacheExtension, that is an excellent idea. i was thinking maybe we one day have more things to add, but if so we should do separate extensions so they can be added separatly.
can we add this field to a group_metadata please? same as here https://github.com/symfony-cmf/CoreBundle/blob/master/Admin/Extension/PublishableExtension.php#L21 but with metadata instead of publish_workflow
I'll finish this tomorrow morning