fix SonataCacheBundle integration related to updatedAt
lsmith77 opened this issue · 5 comments
BaseBlockService::getCacheKeys() expects the block to have an updated at date, which we do not seem to ensure is set, let alone updated.
Just checked the code and the mix:lastModified was already configured on the abstractBlock here: https://github.com/symfony-cmf/BlockBundle/blob/master/Resources/config/doctrine-model/AbstractBlock.phpcr.xml#L26
I thought i have seen this working, however I understand now it doesn't (also from #165). I think the mixin is also used in the MediaBundle and probably won't work there too.
@lsmith77 now that jackalope has a mechanism that is active by default to update the lastmodified date on save, is this issue fixed or something still needs to be done?
yeah, i guess this can now be closed, though the question is of we should have such a property by default?
@lsmith77 so what exactly is missing? the base block does have the last modified date and with 1.1 this date will be populated. do we need to adjust our default block service?
ah ok .. then all is well