symfony-cmf/block-bundle

Symfony 2.5+: LegacyExecutionContext given

pestaa opened this issue · 2 comments

Catchable fatal error: Argument 1 passed to Symfony\Cmf\Bundle\BlockBundle\Doctrine\Phpcr\AbstractBlock::isSettingsValid() must be an instance of Symfony\Component\Validator\ExecutionContext, instance of Symfony\Component\Validator\Context\LegacyExecutionContext given in .../vendor/symfony-cmf/block-bundle/Symfony/Cmf/Bundle/BlockBundle/Doctrine/Phpcr/AbstractBlock.php on line 53

I'm using Symfony 2.5, Sylius dev-master, CMF 1.1 stable with a few bleeding edge packages.

This was discovered in SonataAdminBundle too (see sonata-project/SonataAdminBundle#2027) and promptly fixed by @dbu.

The type annotation might be simply changed to the common interface, but I'm not 100% sure.

Thank you for the great project, by the way, really good to see modern concepts in PHP.

dbu commented

thanks for this report. i can't see how the same fix would not apply. can you please do a PR to change this, and add a note to the CHANGELOG.md file that the interface changed? there is a slight BC for extending classes that overwrite this method.

note that there is #185 too, but this only affects the ActionBlock. unfortunately i have no clue what is happening there.

dbu commented

fixed in #191