Make templates configurable
jrmyio opened this issue · 1 comments
In https://github.com/symfony-cmf/BlockBundle/blob/master/Resources/config/services.xml all the blocks are defined. The block services have a third argument which is the template that gets rendered.
Personally I dislike making a BlockBundle myself to extend the cmf, nor do I like adding templates in app/Resources.
Is it an option to add the templates to the parameters so one can overwrite them?
i guess it makes sense to make them configureable. we should add them to the configuration, like we have it for the class https://github.com/symfony-cmf/BlockBundle/blob/master/DependencyInjection/Configuration.php#L48 and adjust the xml schema accrodingly, and then copy those settings here https://github.com/symfony-cmf/BlockBundle/blob/master/DependencyInjection/CmfBlockExtension.php#L89
having a default value in the configuration will avoid having to actually define <parameter> in the service definition.
do you want to do a pull request with that?