Add test for UriGenerator::resolveConflict
damienflament opened this issue · 2 comments
#91 added a mandatory argument to the UriGeneratorInterface::resolveConflict method (see this commit).
This change was not detected by the tests as this method is not tested.
The test should be added.
Moreover, the ConflictResolverInterface::resolveConflict method declaration and its implementations need to be updated.
i don't understand what you mean with this. #91 is not yet merged. the changes to the interface and implementations happen in #91, no?
The interface of the generator was already modified with #91.
But I don"t modified the interface of the conflict resolver. As it is called by the URI generator and that the generator is stubbed within the tests, I don't need to do it in order to make the tests pass.
I think I will fix it after adding the missing test (related to this issue) maybe in another PR.
Do you prefer I wrap all the changes in the PR #91 as merging it will break the conflict resolving (even if the tests pass).