symfony-cmf/sonata-phpcr-admin-integration-bundle

Wrong admin service id for route admin

ElectricMaxxx opened this issue · 4 comments

IS:
cmf_sonata_admin_integration.route_admin

SHOULD:
cmf_sonata_admin_integration.routing.route_admin

I propose to also rename the SEO extension service id:

Before
cmf_sonata_admin_integration.seo.admin_extension

After
cmf_sonata_admin_integration.seo.extension.metadata

This is consistent with other extension service IDs.

Alongside, the SEO config should be changed to have an extensions.metadata node.

argh, i acidently pushed that fix to master ... :-)
my console was on:

maximilian@maximilian-ThinkPad-T540p:~/OpenSource/Cmf/sonata-admin$ git checkout correct_admin_service_id

but i forgot the enter ...
and pushed with the IDE.
Sorry for that.

But build was green, even when our main icon shows red/error.

We used an incorrect status icon url. Fixed it in 5b83d67