symfony/recipes

[Doctrine Bundle] Pin versions in Dockerfile

LaurentSanson opened this issue · 5 comments

LaurentSanson commented

Hi there,

I've encountered a small issue with the ORM bundle recipe and using the Hadolint on the CI (it all come from the Kevin's template).

Issue :
Error: Dockerfile:51 DL3018 warning: Pin versions in apk add. Instead of apk add <package> use apk add <package>=<version>

How to reproduce :

  • Use the template
  • Add ORM bundle
  • Git push on main branch

I'm guessing we could probably add a version of the package in the recipe as suggested?

Thanks !

maxhelias commented

Hello,
This error should no longer occur with the latest version of recipes : https://github.com/symfony/recipes/blob/main/doctrine/doctrine-bundle/2.9/manifest.json#L19

LaurentSanson commented

Oh great !! Thanks for the quick feedback

LaurentSanson commented

@maxhelias I've just checked the recipes. The one you pointed at is the 2.9 and it's not the latest as there is a 2.10 => https://github.com/symfony/recipes/blob/main/doctrine/doctrine-bundle/2.10/manifest.json#L18

maxhelias commented

I missed 2.10.. which should have the same dockerfile section as 2.9...

LaurentSanson commented

No probs, I've created the PR. Tell me if it needs more info :)

  • 👍1