syncweek-react-aad/react-aad

AAD_LOGIN_SUCCESS event is triggered twice on login

nairmanu opened this issue · 3 comments

nairmanu commented

Library versions

  • react-aad-msal: 2.3.5
  • msal: 1.3.2

Describe the bug
On login, react-aad-msal library sends AAD_LOGIN_SUCCESS event twice in certain situations. This is not specific to login success event. I see multiple events for AAD_ACQUIRED_ID_TOKEN_SUCCESS as well.

I noticed there is a missing await keyword for processLogin() which may or may not be contributing to the issue?

react-aad/packages/react-aad-msal/src/MsalAuthProvider.ts

Line 314 in a7205ef

this.processLogin();

Expected behavior
AAD_LOGIN_SUCCESS should be triggered only once

Desktop (please complete the following information):

  • OS: macOS
  • Browser chrome
  • Version 84.0.4147.105
d3vAdv3ntur3s commented

Experiencing the same @nairmanu

roxkisrover commented

Got same behaviour with LoginType.Redirect scenario:
image

  • 👍1
sanchopancho13 commented

We get the same event sequence reported by @roxkisrover.