syndesisio/syndesis-react

connection detail - validation logic isn't correct

gashcrumb opened this issue · 1 comments

This is a...


[ ] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Documentation issue or request

Description

While refactoring the forms I've found that the logic for the validate button isn't correct on the connection detail page and the connector form page in the connection creation wizard. The validate button only sends the current form values to the backend to show the user if the current settings are correct or not. Validation of required fields etc. are all left to the form property definition, and the response back from the backend is either no errors, meaning that whatever the user has entered was successful in creating a connection, or an error response that carries the error reported by the camel connector making a connection attempt to the target system.

I'm hoping to fix this as part of my form refactoring effort but I may need to track this as a separate effort.

Discovered as part of implementing #322 and #251