syndesisio/syndesis

Specify shell when detecting minishift binary in syndesis CLI

Closed this issue · 0 comments

This is a...


[ ] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Documentation issue or request

Description

After installing setting up Minishift with a fish shell, when running syndesis minishift, I receive the following error when running in either fish or bash:

/tmp/syndesis-cli/commands/minishift: line 87: set: -g: invalid option
set: usage: set [-abefhkmnptuvxBCHP] [-o option-name] [--] [arg ...]
ERROR: Last command exited with 2

For some reason, minishift oc-env is outputting the fish command rather than the bash command, even though my user's default shell is /bin/bash and I ran the syndesis minishift command from a bash shell. That may be an issue with Minishift's shell detection, but since the syndesis scripts are run in bash this can be made more resilient by changing eval(minishift oc-env) to eval(minishift oc-env --shell bash).