syphon-org/syphon

Enable additional flutter_lints rules

AdiAr11 opened this issue · 4 comments

I saw in analysis_options.yaml file that most of the rules are set to false. Also there are some rules missing like prefer_const_declarations. Enabling these will have a good impact.
prefer_const_declarations will identify widgets that are constant and will highly improve performance.

@ereio I can start working on this as well if confirmed!

ereio commented

Flutter linting should already occur under the dev branch as seen here when I was cleaning things up with dart fix

2c1d294

Just want to make sure there isn't more clarity needed around using flutter_lint in the repo. Working on enabling some of the disabled lint rules sounds good otherwise!

Yes a few rules have been set to false in analysis_options.yaml file, which could improve performance. will create a pr, if it's not right or require changes, please let me know

ereio commented

Sounds good to me!