syrusakbary/fastdiff

test_fastdiff.test_native without wasmer fails on 0.2.0

Opened this issue · 2 comments

Over on this build of the conda-forge feedstock for fastdiff, I've come upon:

============================= test session starts ==============================
platform linux -- Python 3.7.3, pytest-3.10.1, py-1.8.0, pluggy-0.12.0
benchmark: 3.0.0 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=5.00us max_time=1.00s calibration_precision=10 warmup=False warmup_iterations=100000)
rootdir: $SRC_DIR, inifile:
plugins: benchmark-3.0.0, cov-2.7.1
collected 6 items

tests/test_fastdiff.py ..F...                                            [100%]

=================================== FAILURES ===================================
_________________________________ test_native __________________________________

    def test_native():
        compared = compare_native("one\ntwo\nthree", "one\ntwo\nfour")
>       assert compared == ['  one', '  two', '- three', '+ four']
E       AssertionError: assert [] == ['  one', '  two', '- three', '+ four']
E         Right contains more items, first extra item: '  one'
E         Use -v to get the full diff

tests/test_fastdiff.py:31: AssertionError

I haven't had a chance to check it out locally, but will get to it when i have a chance... will at least turn the verbosity up...

Previous build of 0.1.4...

ah, because compare_native was explicitly set this way in the wasmer-less case (we don't have that just yet on conda-forge):

https://github.com/syrusakbary/fastdiff/blame/21ec63cf2ee0a435314cd18502d369b3aea8d1eb/python/tests/test_fastdiff.py#L15