Webpack 5 support

Question

Webpack 5 support

ScriptedAlchemy opened this issue 4 years ago · 11 comments

ScriptedAlchemy commented 4 years ago

Any hints on what I need to PR to get Webpack 5 support?

Answer 1 · 2020-04-20T18:36:27.000Z

I have no idea to be fair. Webpack 5 is very different and I haven't seen good documentation for Webpack 5 internals

Answer 2 · 2020-04-21T01:20:48.000Z

Checking the filesystem API of Webpack Core, looks like we are good.

Testing it now, seems to keep on working. Might ping you with a question or two. Im using it to workaround another issue in the webpack core that we haven't yet solved. In conjunction with webpack/webpack#10352

Answer 3 · 2020-04-21T05:51:20.000Z

@ScriptedAlchemy Sure, feel free to ping me with questions

Answer 4 · 2020-04-21T06:43:41.000Z

https://youtu.be/uFZsdShuzxU did a screencast on it :)

Answer 5 · 2020-04-21T08:10:04.000Z

@ScriptedAlchemy Cool, thank you for sharing!

Answer 6 · 2020-09-01T18:58:38.000Z

Got an error:

TypeError: Cannot read property 'data' of undefined
ERR!     at setData (/Users/xxx/.yarn/cache/webpack-virtual-modules-npm-0.2.2-1f43412872-f06d8f3e84.zip/node_modules/webpack-virtual-modules/index.js:84:15)

Answer 7 · 2020-09-01T19:03:02.000Z

@kirill-konshin Because webpack 5 is not supported yet

Answer 8 · 2020-09-01T19:11:57.000Z

Why is this issue closed then :) let's leave it open

Answer 9 · 2020-09-02T05:36:44.000Z

@kirill-konshin Because issue author closed it

Answer 10 · 2020-09-05T07:29:21.000Z

@ScriptedAlchemy @kirill-konshin Fixed via #55 and published in webpack-virtual-modules@0.3.0

Answer 11 · 2020-09-11T19:03:49.000Z

Thank you! I've mentioned the issue in Storybook upgrade ticket.