sysid/sse-starlette

Python type hints

Closed this issue · 5 comments

lukecivantos commented

Hey there!

I was wondering if there were any plans to add types or type stubs to this library.

Thanks!

sysid commented

@lukecivantos , not sure what you mean. Sse-starlette is typed. Can you please elaborate.

ahmedabdou14 commented

I was going to raise the same request here actually. It is going to be super helpful to maybe make EventSourceResponse accept a generic type that specifies the type of content stream sent. I am not sure if this would be of any help to openapi docs, but it would be nice to see the data type sent via sse within redoc and openapi.

  • 👍1
sysid commented

@ahmedabdou14 thanks for adding to the topic. I am very open for these ideas. PRs are welcome!

ahmedabdou14 commented

Perfect then ;)
A PR might come very late though, i am super busy this month
You can go ahead and assign me to this issue

sysid commented

@ahmedabdou14 , closing this for now, but PR is welcome any time. Hope this is ok.

  • 👍1