C90 compatibility is only enforced in the CI

Question

C90 compatibility is only enforced in the CI

MarcelWaldvogel opened this issue 6 years ago · 3 comments

Running make or make check on the local system does not complain about C99 constructs (such as defining the loop variable in the loop itself, e.g. 2596c5d).

This makes it hard to create code which passes CI.

Can this be changed in the Makefile? Or can the requirement to be C90 compatible be relaxed?

Answer 1 · 2018-10-02T18:55:27.000Z

I think you should be able to achieve that by adding '--std=c90' to the extra_compile_args of the constructor for the Extension objects in setup.py.

Answer 2 · 2018-10-02T19:24:17.000Z

Thanks!

But my main question was: Why is C90 enforced at all (instead of at least C99)? This is 2018. And it will only run on a machine with very recent setup (systemd was created decades after C90)

Answer 3 · 2018-10-02T19:31:28.000Z

Yes, I agree. Unfortunately the maintainers are very quiet here.

I just came to see if the documentation was updated regarding systemd-activate -> systemd-socket-activate, which you already did in one of your commits.