syt123450/giojs

Missing countries

AlexisAnzieu opened this issue · 10 comments

AlexisAnzieu commented

Hi!

When i tried to connect it with youtube stats, I had some issues with countrycode. I notice some missing countries from your singleton object :

I only found it for now but I will post update if there are more of them.

Thanks for the lib anyway !

syt123450 commented

Thanks for reminding us about the missing countries. We will add them to our library based on your suggestion. However, in order to add new countries, we need to update not only the country object but also the MapIndex data, which may take time.

Using "ZZ" to represent UNKNOWN countries is an amazing idea, and it is really exciting to add this feature to Gio.js. We can create another issue to work on it right now. Can you give us a hand? @AlexisAnzieu

syt123450 commented

Can you help to check and add missing countries in countryData object @BoTime

syt123450 commented

Can you help to update the mapIndex data for missing country? @lq3297401

AlexisAnzieu commented

yes no problem @syt123450.
I've created #88 and will work on it as soon as "ZZ" is added to the object and Index !

syt123450 commented

Thanks so much for your help ~ Looking forward for this feature! @AlexisAnzieu

syt123450 commented

@AlexisAnzieu Hi, I have added the missing country code: RE, HK, GP for Gio.js and update the lib in "build" folder. As HK is an inalienable part of the Chinese territory, every time referring to country code HK, Gio.js will highlight the whole Chinese territory. Thanks for your bug report, hoping this kind of fix can meet your requirement~

AlexisAnzieu commented

@syt123450 Great ! What about "ZZ" code ? I think that it could be placed in the middle of an ocean 🌊

syt123450 commented

@AlexisAnzieu How about ignore the json object in the list whose "e" or "i" is "ZZ"? Just my imagination, if we place the ZZ's position in a specific ocean, it has a sense that a country exports something into ocean. (o.o)

AlexisAnzieu commented

Hmmm sure ! Is it an issue if your ZZ object didn't get any geopoint location in your CountryData.js ?

syt123450 commented

@AlexisAnzieu Just a draft idea, can we check the "ZZ" in GeometryDataProcessor.js, and ignore the object which contains "ZZ", then write a markdown documentation about the usage of country code, and "ZZ" feature? I create a WIP pr #96 , which only has some basic pseudocode for this idea. If this idea is feasible, we can work together to complete it~

  • 👍1